Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] Innitial cleanup of AbstractST #9525

Merged
merged 5 commits into from Jan 12, 2024
Merged

[ST] Innitial cleanup of AbstractST #9525

merged 5 commits into from Jan 12, 2024

Conversation

jankalinic
Copy link
Contributor

Type of change

  • Refactoring

Description

This PR is first part of AbstractST cleanup dealing with unnecessary variables stored multiple times on multiple places.

Checklist

  • Write tests
  • Make sure all tests pass
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@jankalinic jankalinic self-assigned this Jan 8, 2024
@jankalinic jankalinic added this to the 0.40.0 milestone Jan 8, 2024
@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --profile=regression

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: regression
GROUPS:
TEST_CASE:
TOTAL: 284
PASS: 280
FAIL: 2
SKIP: 2
BUILD_NUMBER: 1
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

  • testMultipleRoutes in io.strimzi.systemtest.kafka.listeners.MultipleListenersST
  • testOperandsWithRestrictedSecurityProfile in io.strimzi.systemtest.security.PodSecurityProfilesST

Re-run command:
@strimzi-ci run tests --profile=regression --testcase=io.strimzi.systemtest.kafka.listeners.MultipleListenersST#testMultipleRoutes,io.strimzi.systemtest.security.PodSecurityProfilesST#testOperandsWithRestrictedSecurityProfile

@jankalinic jankalinic marked this pull request as ready for review January 9, 2024 12:09
@im-konge
Copy link
Member

im-konge commented Jan 9, 2024

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jankalinic
cleanup AbstractST
7875e1d 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic
cleanup AbstractST p2
65c7ba7 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic
cleanup AbstractST p3
93fbd9a 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic
fix for the shared user name in httpbridge test secret
cf1d1be 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@im-konge
Copy link
Member

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

see-quick
see-quick approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits 👍 Thanks for the PR

systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java Outdated Show resolved Hide resolved
...test/src/test/java/io/strimzi/systemtest/kafka/dynamicconfiguration/DynamicConfSharedST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/MultipleListenersST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
@jankalinic
fix for comments
f910a01 
Signed-off-by: jkalinic <jkalinic@redhat.com>
@im-konge
Copy link
Member

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jankalinic jankalinic added ready for merge Label for PRs which are ready for merge and removed needs review labels Jan 12, 2024
@Frawless Frawless merged commit e347982 into strimzi:main Jan 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frawless Frawless Frawless approved these changes

@see-quick see-quick see-quick approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@jankalinic jankalinic

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jankalinic @strimzi-ci @im-konge @Frawless @see-quick