[ST] Upgrade/downgrade - specify file path for Kafka in the YAML files #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
see-quick
approved these changes
Jan 9, 2024
systemtest/src/main/java/io/strimzi/systemtest/upgrade/CommonVersionModificationData.java
Show resolved
Hide resolved
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
reviewed
Jan 9, 2024
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Show resolved
Hide resolved
Frawless
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The file paths to the examples of Kafka are currently hard-coded inside the upgrade/downgrade tests, which can be a problem in case that the file path is changed between versions.
This PR adds new fields to upgrade/downgrade YAML files, making possible to specify full path to Kafka YAML files.
Checklist