In KafkaAgentClient use generic keystore password instead of p12 password #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>
scholzj
approved these changes
Jan 10, 2024
ppatierno
approved these changes
Jan 10, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tinaselenge
approved these changes
Jan 10, 2024
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamj-m
pushed a commit
to jamesfarlow/strimzi-kafka-operator
that referenced
this pull request
Feb 1, 2024
…word (strimzi#9538) Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
As part of issue 8721 the KafkaAgentClient was swapped to using the PEM certificate rather than the PKCS12 one. However when creating the JKS keystore for the client we still use the PKCS12 password. Since the keystore is never written to disk, the password is never used to verify the keystore, so it shouldn't matter what the password is. This change uses a generic password of "changeit" to remove dependence on the
cluster-operator.passwordvalue in the Kubernetes secret.Checklist
Please go through this checklist and make sure all applicable tasks have been done