Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system test] Update Azure KRaft pipelines to run KRaft #9557

Merged

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Jan 15, 2024

Type of change

  • Bugfix

Description

Currently, we do not run all Azure profiles as KRaft (as we should). This PR fixes such a problem.

Checklist

  • Make sure all tests pass

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick self-assigned this Jan 15, 2024
@see-quick see-quick added this to the 0.40.0 milestone Jan 15, 2024
@see-quick
Copy link
Member Author

/azp list

@see-quick
Copy link
Member Author

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I really set it only for one job and then randomly selected the same job to check it works? Sorry 🤦

@see-quick
Copy link
Member Author

see-quick commented Jan 15, 2024

Did I really set it only for one job and then randomly selected the same job to check it works? Sorry 🤦

No problem, it was a bad review from my side also :/.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Copy link
Member Author

There is a one-fail, which I fixed in the previous commit.

Conditions:
	Type: Warning
	Message: The .spec.zookeeper section in the Kafka custom resource is ignored in KRaft mode and should be removed from the custom resource.
	Type: Warning
	Message: The .spec.kafka.replicas property in the Kafka custom resource is ignored when node pools are used and should be removed from the custom resource.
	Type: Warning
	Message: The .spec.kafka.storage section in the Kafka custom resource is ignored when node pools are used and should be removed from the custom resource.
	Type: NotReady
	Message: The Kafka cluster my-cluster-74fcefe3 is invalid: [At least one KafkaNodePool with the controller role and at least one replica is required when KRaft mode is enabled]

I would not trigger the pipeline for this one change okay? :)

@im-konge
Copy link
Member

@see-quick I think we should move the whole test to run in the KRaft mode, but for now, I guess that's good
Thanks

@see-quick
Copy link
Member Author

Hmm it seems we have failed this test case but my change does not cause it

[ERROR] Errors: 
[ERROR] io.strimzi.operator.cluster.operator.assembly.KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext)
[ERROR]   Run 1: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-a-2 to become ready
[ERROR]   Run 2: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-b-3 to become ready
[ERROR]   Run 3: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-b-4 to become ready
[ERROR]   Run 4: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-b-4 to become ready
[ERROR]   Run 5: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-a-2 to become ready
[ERROR]   Run 6: KafkaAssemblyOperatorWithPoolsMockTest.testReconcileReplacesAllDeletedSecrets(VertxTestContext) » FatalProblem Error while waiting for restarted pod my-cluster-pool-a-2 to become ready

even 6 runs are not enough to get this test case passed. I would re-trigger the build, but we should fix such a test. :) I don't know if this is happening on other PRs but I would assume yes.

@see-quick see-quick added the ready for merge Label for PRs which are ready for merge label Jan 16, 2024
@see-quick see-quick merged commit 3339543 into strimzi:main Jan 16, 2024
13 checks passed
adamj-m pushed a commit to jamesfarlow/strimzi-kafka-operator that referenced this pull request Feb 1, 2024
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants