Improve test coverage of KafkaAssemblyOperator in KRaft mode
#9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
@ppatierno Any chance you have a look at this? Thanks. |
see-quick
approved these changes
Jan 19, 2024
jankalinic
pushed a commit
to jankalinic/strimzi-kafka-operator
that referenced
this pull request
Feb 8, 2024
…zi#9558) Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves the test coverage of
KafkaAssemblyOperatorin Kraft mode. It is based on the existingKafkaAssemblyOperatorWithPoolsTest, but with focus on Kraft. It also moves the one (and only) KRaft related test fromKafkaAssemblyOperatorWithPoolsTestinto the new class.Checklist