Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly display disk size in KRaft dashboards #9567

Merged
merged 2 commits into from Jan 18, 2024

Conversation

Frawless
Copy link
Member

Type of change

  • Bugfix

Description

Current KRaft dashboard doesn't show disk space properly because it doesn't count with nodepools. The same issue was also for Kafka dashboard but it was fixed in #8937

Screenshot after change:
image

Checklist

  • Reference relevant issue(s) and close them after merging
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
@Frawless Frawless requested a review from scholzj January 18, 2024 13:14
@scholzj
Copy link
Member

scholzj commented Jan 18, 2024

Thanks @Frawless!

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks Jakub!

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@scholzj scholzj added this to the 0.40.0 milestone Jan 18, 2024
@scholzj scholzj merged commit 81c17fd into strimzi:main Jan 18, 2024
13 checks passed
@Frawless Frawless deleted the fix-kraft-dashboard branch January 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants