Refactor connector preparation our of KafkaMirrorMaker2AssemblyOperator
#9593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or - Closes strimzi#9419 Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Jan 25, 2024
adamj-m
pushed a commit
to jamesfarlow/strimzi-kafka-operator
that referenced
this pull request
Feb 1, 2024
…tor` (strimzi#9593) Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR refactors how the Kafka Mirror Maker 2 connectors are managed in
KafkaMirrorMaker2AssemblyOperator. It factors the preparation of the connectors into a separate classKafkaMirrorMaker2Connectorslinked fromKafkaMirrorMaker2Cluster. This class doesn't do any reconciliation, it only prepares the connector specifications.The reconciliation is still handled by
KafkaMirrorMaker2AssemblyOperator. The code there was only slightly simplified to use the new class.This refactoring allowed to easily add more unit tests for the various connector configurations that should hopefully help us to allow issues such as #9418 in the future.
This should resolve #9419.
Checklist