Check assigned partition-replicas when changing node roles #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Jan 31, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaPool.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaPool.java
Outdated
Show resolved
Hide resolved
...-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/BrokersInUseCheck.java
Show resolved
Hide resolved
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaClusterCreator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
force-pushed
the
check-assigned-replicas-when-changing-roles
branch
from
57e22f8
to
6a371b8
Compare
ppatierno
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR extends the scale-down check to also prevent removing the broker role from mixed nodes in Kraft when they still have any assigned partition replicas.
To do this, it refactors the
PreventBrokerScaleDownCheckto not check directly if the broker IDs being scaled-down are in use. It now returns the list of brokers in use and the check is done in theKafkaClusterCreatorclass where it is used for both the scale-down check as well as for the broker-role-removal check. It also renames this class toBrokersInUseCheckto better correspond to the new role and improves the unit tests.Documentation will be updated in a separate PR.
This should resolve #9436.
Checklist