Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and store ST configuration in yaml #9630

Merged
merged 2 commits into from Feb 1, 2024

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Feb 1, 2024

Type of change

  • Enhancement / new feature

Description

Read and store configuration from environment variables for systemtest run in yaml format.
Configuration is automatically created for every systemtest run so test run can be easily reproduces with just passing env file and not writing all env vars.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Make sure all tests pass
  • Update documentation

Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys added this to the 0.40.0 milestone Feb 1, 2024
@kornys kornys marked this pull request as draft February 1, 2024 10:17
@kornys kornys marked this pull request as ready for review February 1, 2024 10:27
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits, thanks for the PR :)

development-docs/TESTING.md Outdated Show resolved Hide resolved
Signed-off-by: David Kornel <kornys@outlook.com>
@kornys kornys requested a review from im-konge February 1, 2024 10:40
@kornys kornys added the ready for merge Label for PRs which are ready for merge label Feb 1, 2024
@see-quick see-quick merged commit 00bf88e into strimzi:main Feb 1, 2024
13 checks passed
@kornys kornys deleted the store-yaml-config branch February 1, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants