[ST] Fixups to few failing tests #9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Pull request contains merge conflicts. |
Frawless
approved these changes
Feb 5, 2024
im-konge
force-pushed
the
fixups-to-nightlies
branch
from
d4a201a
to
6166f78
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 task
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
approved these changes
Feb 6, 2024
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
im-konge
force-pushed
the
fixups-to-nightlies
branch
from
a4250ed
to
e5e30bb
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jankalinic
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes several failing (or flaky) tests:
PodSecurityProfilesST.testOperandsWithRestrictedSecurityProfile - issue that the Namespace was not every time correctly labeled - now the Namespace will be labeled in a loop and in case of exception, it just tries again (credit @kornys )
ConnectST.testConnectorTaskAutoRestart - test which was disabled before, but now "somehow" works - it actually fails from time to time on the infinite restart of EchoSink Connector - there was issue with how we were sending the messages. In case that we send all messages, that are set as a failed count, the exception is thrown and the Connector is restarted. But because the exception is in
put()method of theEchoSinkTask, there is a possibility that the offset of the records is not committed. That causes the "infinite auto-restart".MultipleListenersST.testMultipleRoutes - from time to time the generated name of the Kafka cluster with name of particular NodePool hits the limit of 63 chars, causing issues with Routes. The idea is to change the prefix of the NodePool, so it will be shorter and we will not hit the limit.
ConnectBuilderST.testUpdateConnectWithAnotherPlugin - issue with
nullplugins in the status. I added a method for waiting until Connect status contains the list of pluginsAlso, there are many tests failing because of
assertNoCoErrorsLoggedcheck, which finds some errors/warnings in CO log - some of the things are just warnings that we should fix in our STs, some of the failures are just wrongly matched to the whitelisted pattern, some of the errors needs fix or addition to whitelist. For now, I disabled this check and created #9648 to track the fix and enablement.Checklist