Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Remove unused methods from the KafkaNodePoolResource class #9650

Merged
merged 1 commit into from Feb 7, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Feb 6, 2024

Type of change

  • Refactoring

Description

Inside KafkaNodePoolResource are methods that are not used anywhere in STs. Plus, in case of getLabelSelector(final String poolName, final ProcessRoles processRoles) it's usage little bit confuse anyone when watching rolling update of the Pods, as we can see something similar to this in the log of the test execution:

2024-02-06 12:29:39 [main] INFO  [RollingUpdateUtils:79] Waiting for component matching LabelSelector(matchExpressions=[], matchLabels={strimzi.io/pool-name=kafka, strimzi.io/kind=Kafka, strimzi.io/broker-role=true}, additionalProperties={}) -> co-namespace/null-kafka rolling update
2024-02-06 12:30:58 [main] INFO  [RollingUpdateUtils:90] Component matching LabelSelector(matchExpressions=[], matchLabels={strimzi.io/pool-name=kafka, strimzi.io/kind=Kafka, strimzi.io/broker-role=true}, additionalProperties={}) -> co-namespace/null-kafka has been successfully rolled
2024-02-06 12:30:59 [main] INFO  [RollingUpdateUtils:102] Waiting for 3 Pod(s) of co-namespace/null-kafka to be ready

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge requested a review from a team February 6, 2024 17:55
@im-konge im-konge self-assigned this Feb 6, 2024
@im-konge im-konge added this to the 0.40.0 milestone Feb 6, 2024
Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks for PR!

@im-konge
Copy link
Member Author

im-konge commented Feb 6, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit ac80e5f into strimzi:main Feb 7, 2024
17 checks passed
@im-konge im-konge deleted the fix-rolling-update-info branch February 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants