[ST] default builders for plain/tls internal clients #9658

henryZrncik · 2024-02-08T01:12:38Z

Type of change

Refactoring

Description

Changes described by files:

`TestConstants` and `TestStorage`

Concerned mainly with new fields (added for smooth work with continuous clients)

continuousProducerName (All 3 same as their basic counterparts but with extra suffix)
continuousConsumerName
continuousTopicName
continuousMessageCount (300 in comparison to 100)

`ClientUtils`

Primarily following methods added:

getInstantPlainClientBuilder
getInstantTlsClientBuilder
getContinuousPlainClientBuilder
getContinuousTlsClientBuilder

Continuous methods are waiting for continuous, clients with respective teststorage.fields.

as these clients are basically hello world (used to be called that way).
there is additionaly namespace and default user which are there for completness.

Any of them can be changed and as can be seen in specific tests they sometimes are which makes it visible what is actually important about given producer/consumer.

additional helper method waitForContinuousClientSuccess which waits specifically for continuous clients.

`<specific>ST` classes

changes include:

replacing Environment.TEST_SUITE_NAMESPACE with testStorage atlernative.
removal of unncessary names for producer and consumers espcially with prefixes continuous or <random> if not needed
some continuous client time and message shortening due to very long waiting just for message sending
slight refactors and removals of unnecessary methods.

see-quick · 2024-02-08T08:13:49Z

/azp run regression

azure-pipelines · 2024-02-08T08:14:00Z

Azure Pipelines successfully started running 1 pipeline(s).

im-konge

I didn't go through all the changes, but I have few comments that I would like to have addressed before continuing.

As I mentioned offline, having one or two "default" methods that sets completely everything makes the tests confusing and it's not really clear to me, what are the requirements that need to be met for successfully sending/receiving messages.

If you get this "default" clients with everything set, some of the newbies will don't know that for SCRAM-SHA you need to set the username and create a KafkaUser. Same for TLS.

So I would create methods for creating the clients based on TestStorage, yes, but I would not have one method for all of the use-cases, but multiple methods that will cover multiple auth options. At least that will be (for me and I guess for anyone else) clearer to see, what's really going on and what is needed to be done before the message transmission.

systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java

systemtest/src/main/java/io/strimzi/systemtest/utils/ClientUtils.java

im-konge · 2024-02-27T20:29:51Z

/azp run regression

azure-pipelines · 2024-02-27T20:30:03Z

Azure Pipelines successfully started running 1 pipeline(s).

henryZrncik · 2024-02-28T22:41:22Z

@strimzi-ci run tests --testcase=RackAwarenessST --profile=all --env=STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

strimzi-ci · 2024-02-28T22:42:29Z

▶️ Build started - check Jenkins for more info. ▶️

strimzi-ci · 2024-02-28T23:43:32Z

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: RackAwarenessST
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0
BUILD_NUMBER: 9
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

henryZrncik · 2024-02-29T10:11:44Z

@strimzi-ci run tests --profile=all --env=STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

strimzi-ci · 2024-02-29T10:14:39Z

▶️ Build started - check Jenkins for more info. ▶️

strimzi-ci · 2024-03-01T08:57:13Z

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE:
TOTAL: 191
PASS: 150
FAIL: 38
SKIP: 3
BUILD_NUMBER: 10
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

❗ Test Failures ❗

testCorsForbidden in io.strimzi.systemtest.bridge.HttpBridgeCorsST
testSendSimpleMessage in io.strimzi.systemtest.bridge.HttpBridgeST
testReceiveSimpleMessageTlsScramSha in io.strimzi.systemtest.bridge.HttpBridgeScramShaST
testReceiveSimpleMessageTls in io.strimzi.systemtest.bridge.HttpBridgeTlsST
testKafkaQuotasPluginIntegration in io.strimzi.systemtest.kafka.QuotasST
testKafkaZookeeperAndKafkaConnectWithJMX in io.strimzi.systemtest.metrics.JmxST
io.strimzi.systemtest.metrics.MetricsST
testKafkaMirrorMaker2ConnectorsState in io.strimzi.systemtest.mirrormaker.MirrorMaker2ST
testScaleMirrorMakerUpAndDownToZero in io.strimzi.systemtest.mirrormaker.MirrorMakerST
testMultipleCOsInDifferentNamespaces in io.strimzi.systemtest.operators.MultipleClusterOperatorsST
testPauseReconciliationInKafkaRebalanceAndTopic in io.strimzi.systemtest.operators.ReconciliationST
testAddingAndRemovingJbodVolumes in io.strimzi.systemtest.rollingupdate.AlternativeReconcileTriggersST
testNPWhenOperatorIsInDifferentNamespaceThanOperand in io.strimzi.systemtest.security.NetworkPoliciesST
testAutoReplaceAllCaKeysTriggeredByAnno in io.strimzi.systemtest.security.SecurityST
io.strimzi.systemtest.security.oauth.OauthAuthorizationST
io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST
io.strimzi.systemtest.security.oauth.OauthPlainST
io.strimzi.systemtest.security.oauth.OauthScopeST
io.strimzi.systemtest.security.oauth.OauthTlsST
testDrainCleanerWithComponents in io.strimzi.systemtest.specific.DrainCleanerST
testKafkaClusterUpgrade in io.strimzi.systemtest.upgrade.kraft.KRaftKafkaUpgradeDowngradeST
testDowngradeStrimziVersion testDowngradeStrimziVersion-HEAD-0.39.0 in io.strimzi.systemtest.upgrade.kraft.KRaftStrimziDowngradeST
testUpgradeAcrossVersionsWithNoKafkaVersion in io.strimzi.systemtest.upgrade.kraft.KRaftStrimziUpgradeST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.bridge.HttpBridgeCorsST#testCorsForbidden,io.strimzi.systemtest.bridge.HttpBridgeST#testSendSimpleMessage,io.strimzi.systemtest.bridge.HttpBridgeScramShaST#testReceiveSimpleMessageTlsScramSha,io.strimzi.systemtest.bridge.HttpBridgeTlsST#testReceiveSimpleMessageTls,io.strimzi.systemtest.kafka.QuotasST#testKafkaQuotasPluginIntegration,io.strimzi.systemtest.metrics.JmxST#testKafkaZookeeperAndKafkaConnectWithJMX,io.strimzi.systemtest.metrics.MetricsST,io.strimzi.systemtest.mirrormaker.MirrorMaker2ST#testKafkaMirrorMaker2ConnectorsState,io.strimzi.systemtest.mirrormaker.MirrorMakerST#testScaleMirrorMakerUpAndDownToZero,io.strimzi.systemtest.operators.MultipleClusterOperatorsST#testMultipleCOsInDifferentNamespaces,io.strimzi.systemtest.operators.ReconciliationST#testPauseReconciliationInKafkaRebalanceAndTopic,io.strimzi.systemtest.rollingupdate.AlternativeReconcileTriggersST#testAddingAndRemovingJbodVolumes,io.strimzi.systemtest.security.NetworkPoliciesST#testNPWhenOperatorIsInDifferentNamespaceThanOperand,io.strimzi.systemtest.security.SecurityST#testAutoReplaceAllCaKeysTriggeredByAnno,io.strimzi.systemtest.security.oauth.OauthAuthorizationST,io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST,io.strimzi.systemtest.security.oauth.OauthPlainST,io.strimzi.systemtest.security.oauth.OauthScopeST,io.strimzi.systemtest.security.oauth.OauthTlsST,io.strimzi.systemtest.specific.DrainCleanerST#testDrainCleanerWithComponents,io.strimzi.systemtest.upgrade.kraft.KRaftKafkaUpgradeDowngradeST#testKafkaClusterUpgrade,io.strimzi.systemtest.upgrade.kraft.KRaftStrimziDowngradeST#testDowngradeStrimziVersion testDowngradeStrimziVersion-HEAD-0.39.0,io.strimzi.systemtest.upgrade.kraft.KRaftStrimziUpgradeST#testUpgradeAcrossVersionsWithNoKafkaVersion

henryZrncik · 2024-03-04T08:50:01Z

@strimzi-ci run tests --profile=all --env=STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

strimzi-ci · 2024-03-04T08:53:08Z

▶️ Build started - check Jenkins for more info. ▶️

strimzi-ci · 2024-03-05T07:57:51Z

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE:
TOTAL: 191
PASS: 153
FAIL: 35
SKIP: 3
BUILD_NUMBER: 14
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

❗ Test Failures ❗

testCorsForbidden in io.strimzi.systemtest.bridge.HttpBridgeCorsST
testReceiveSimpleMessage in io.strimzi.systemtest.bridge.HttpBridgeST
testReceiveSimpleMessageTlsScramSha in io.strimzi.systemtest.bridge.HttpBridgeScramShaST
testReceiveSimpleMessageTls in io.strimzi.systemtest.bridge.HttpBridgeTlsST
testKafkaQuotasPluginIntegration in io.strimzi.systemtest.kafka.QuotasST
testKafkaZookeeperAndKafkaConnectWithJMX in io.strimzi.systemtest.metrics.JmxST
io.strimzi.systemtest.metrics.MetricsST
testKMM2RollAfterSecretsCertsUpdateTLS in io.strimzi.systemtest.mirrormaker.MirrorMaker2ST
testScaleMirrorMakerUpAndDownToZero in io.strimzi.systemtest.mirrormaker.MirrorMakerST
testMultipleCOsInDifferentNamespaces in io.strimzi.systemtest.operators.MultipleClusterOperatorsST
testNPGenerationEnvironmentVariable in io.strimzi.systemtest.security.NetworkPoliciesST
testAutoReplaceAllCaKeysTriggeredByAnno in io.strimzi.systemtest.security.SecurityST
io.strimzi.systemtest.security.oauth.OauthAuthorizationST
io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST
io.strimzi.systemtest.security.oauth.OauthPlainST
io.strimzi.systemtest.security.oauth.OauthScopeST
io.strimzi.systemtest.security.oauth.OauthTlsST
testDrainCleanerWithComponents in io.strimzi.systemtest.specific.DrainCleanerST
testKafkaClusterUpgrade in io.strimzi.systemtest.upgrade.kraft.KRaftKafkaUpgradeDowngradeST
testDowngradeStrimziVersion testDowngradeStrimziVersion-HEAD-0.39.0 in io.strimzi.systemtest.upgrade.kraft.KRaftStrimziDowngradeST
testUpgradeAcrossVersionsWithNoKafkaVersion in io.strimzi.systemtest.upgrade.kraft.KRaftStrimziUpgradeST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.bridge.HttpBridgeCorsST#testCorsForbidden,io.strimzi.systemtest.bridge.HttpBridgeST#testReceiveSimpleMessage,io.strimzi.systemtest.bridge.HttpBridgeScramShaST#testReceiveSimpleMessageTlsScramSha,io.strimzi.systemtest.bridge.HttpBridgeTlsST#testReceiveSimpleMessageTls,io.strimzi.systemtest.kafka.QuotasST#testKafkaQuotasPluginIntegration,io.strimzi.systemtest.metrics.JmxST#testKafkaZookeeperAndKafkaConnectWithJMX,io.strimzi.systemtest.metrics.MetricsST,io.strimzi.systemtest.mirrormaker.MirrorMaker2ST#testKMM2RollAfterSecretsCertsUpdateTLS,io.strimzi.systemtest.mirrormaker.MirrorMakerST#testScaleMirrorMakerUpAndDownToZero,io.strimzi.systemtest.operators.MultipleClusterOperatorsST#testMultipleCOsInDifferentNamespaces,io.strimzi.systemtest.security.NetworkPoliciesST#testNPGenerationEnvironmentVariable,io.strimzi.systemtest.security.SecurityST#testAutoReplaceAllCaKeysTriggeredByAnno,io.strimzi.systemtest.security.oauth.OauthAuthorizationST,io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST,io.strimzi.systemtest.security.oauth.OauthPlainST,io.strimzi.systemtest.security.oauth.OauthScopeST,io.strimzi.systemtest.security.oauth.OauthTlsST,io.strimzi.systemtest.specific.DrainCleanerST#testDrainCleanerWithComponents,io.strimzi.systemtest.upgrade.kraft.KRaftKafkaUpgradeDowngradeST#testKafkaClusterUpgrade,io.strimzi.systemtest.upgrade.kraft.KRaftStrimziDowngradeST#testDowngradeStrimziVersion testDowngradeStrimziVersion-HEAD-0.39.0,io.strimzi.systemtest.upgrade.kraft.KRaftStrimziUpgradeST#testUpgradeAcrossVersionsWithNoKafkaVersion

see-quick · 2024-03-06T09:26:11Z

/azp list

azure-pipelines · 2024-03-06T09:26:17Z

CI/CD Pipelines for this repository: build system-tests upgrade helm-acceptance regression acceptance namespace-rbac-scope-acceptance namespace-rbac-scope-regression all-strimzi-system-tests feature-gates-regression operators-release operators-cve-rebuild kraft-regression bridge migration

see-quick · 2024-03-06T09:26:35Z

/azp run feature-gates-regression

azure-pipelines · 2024-03-06T09:26:46Z

Azure Pipelines successfully started running 1 pipeline(s).

henryZrncik · 2024-03-07T09:32:04Z

@strimzi-ci run tests --profile=all --testcase=HttpBridgeST,MirrorMaker2ST --parallel-count=1 --env=STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

strimzi-ci · 2024-03-07T09:34:59Z

▶️ Build started - check Jenkins for more info. ▶️

strimzi-ci · 2024-03-07T12:19:17Z

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE: HttpBridgeST,MirrorMaker2ST
TOTAL: 19
PASS: 17
FAIL: 2
SKIP: 0
BUILD_NUMBER: 30
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 1
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

❗ Test Failures ❗

testSendSimpleMessage in io.strimzi.systemtest.bridge.HttpBridgeST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.bridge.HttpBridgeST#testSendSimpleMessage

azure-pipelines · 2024-03-20T13:05:50Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: hzrncik <hzrncik@redhat.com>

…using sink Signed-off-by: hzrncik <hzrncik@redhat.com>

Signed-off-by: hzrncik <hzrncik@redhat.com>

…well Signed-off-by: hzrncik <hzrncik@redhat.com>

Signed-off-by: hzrncik <hzrncik@redhat.com>

see-quick · 2024-03-21T08:48:27Z

/azp run regression

azure-pipelines · 2024-03-21T08:48:41Z

Azure Pipelines successfully started running 1 pipeline(s).

henryZrncik · 2024-03-22T06:56:03Z

@see-quick last fail unrelated to the PR.

Signed-off-by: hzrncik <hzrncik@redhat.com>

henryZrncik requested review from im-konge and see-quick February 8, 2024 01:12

henryZrncik added the System tests label Feb 8, 2024

henryZrncik added this to the 0.40.0 milestone Feb 8, 2024

henryZrncik force-pushed the clients branch from b775999 to e49dc70 Compare February 8, 2024 01:33

im-konge requested changes Feb 8, 2024

View reviewed changes

henryZrncik marked this pull request as draft February 9, 2024 09:10

henryZrncik force-pushed the clients branch from e49dc70 to 1a0fc95 Compare February 27, 2024 19:21

henryZrncik force-pushed the clients branch from 1a0fc95 to c36c2c1 Compare February 28, 2024 22:28

henryZrncik force-pushed the clients branch from c36c2c1 to 37d0f8b Compare March 4, 2024 08:48

henryZrncik added 18 commits March 20, 2024 19:12

rebase client refactor

db6bfa1

Signed-off-by: hzrncik <hzrncik@redhat.com>

fix client call plain instead of tls

2ac3d4a

Signed-off-by: hzrncik <hzrncik@redhat.com>

adding back consumer gorup in KafkaVersionST test

0370e6b

Signed-off-by: hzrncik <hzrncik@redhat.com>

todo for flaky test

cefbbbe

Signed-off-by: hzrncik <hzrncik@redhat.com>

upgrade client call fix and increase timeouts to prevent flakies

6cf1461

Signed-off-by: hzrncik <hzrncik@redhat.com>

remove default client builder

ea74e75

Signed-off-by: hzrncik <hzrncik@redhat.com>

client utils java doc

d8f4baf

Signed-off-by: hzrncik <hzrncik@redhat.com>

move generateNewConsumer group into clients rather than ClientUtils

08e9489

Signed-off-by: hzrncik <hzrncik@redhat.com>

addition of getUsername into default tls client builders

6037cd0

Signed-off-by: hzrncik <hzrncik@redhat.com>

removal of useless specification of expected number of messages when …

c8f2d06

…using sink Signed-off-by: hzrncik <hzrncik@redhat.com>

removal of fixes, cleanup and minor recommendations addition

c34bd01

Signed-off-by: hzrncik <hzrncik@redhat.com>

add bootstrap server parameter to client utils

815213b

Signed-off-by: hzrncik <hzrncik@redhat.com>

scramsha client utils added and client builder calls refactored

293b991

Signed-off-by: hzrncik <hzrncik@redhat.com>

remove spacing

89ea9a7

Signed-off-by: hzrncik <hzrncik@redhat.com>

fix fails except testSendMessagesTlsAuthenticated failing on mai nas …

6bdd348

…well Signed-off-by: hzrncik <hzrncik@redhat.com>

upgrades client message count change

8810dda

Signed-off-by: hzrncik <hzrncik@redhat.com>

rebase

24a0abb

Signed-off-by: hzrncik <hzrncik@redhat.com>

restricted pod security profille add restriction

23eaa15

Signed-off-by: hzrncik <hzrncik@redhat.com>

henryZrncik force-pushed the clients branch from 70a460e to 23eaa15 Compare March 20, 2024 18:19

henryZrncik added the needs review label Mar 20, 2024

henryZrncik requested a review from see-quick March 21, 2024 08:47

see-quick assigned henryZrncik Mar 21, 2024

see-quick removed the needs review label Mar 21, 2024

see-quick added the ready for merge Label for PRs which are ready for merge label Mar 22, 2024

see-quick merged commit dd0826b into strimzi:main Mar 22, 2024
21 checks passed

steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Apr 2, 2024

[ST] default builders for plain/tls internal clients (strimzi#9658)

737a0cb

Signed-off-by: hzrncik <hzrncik@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ST] default builders for plain/tls internal clients #9658

[ST] default builders for plain/tls internal clients #9658

henryZrncik commented Feb 8, 2024 •

edited

see-quick commented Feb 8, 2024

azure-pipelines bot commented Feb 8, 2024

im-konge left a comment

im-konge commented Feb 27, 2024

azure-pipelines bot commented Feb 27, 2024

henryZrncik commented Feb 28, 2024

strimzi-ci commented Feb 28, 2024

strimzi-ci commented Feb 28, 2024

henryZrncik commented Feb 29, 2024

strimzi-ci commented Feb 29, 2024

strimzi-ci commented Mar 1, 2024

henryZrncik commented Mar 4, 2024

strimzi-ci commented Mar 4, 2024

strimzi-ci commented Mar 5, 2024

see-quick commented Mar 6, 2024

azure-pipelines bot commented Mar 6, 2024

see-quick commented Mar 6, 2024

azure-pipelines bot commented Mar 6, 2024

henryZrncik commented Mar 7, 2024

strimzi-ci commented Mar 7, 2024

strimzi-ci commented Mar 7, 2024

azure-pipelines bot commented Mar 20, 2024

see-quick commented Mar 21, 2024

azure-pipelines bot commented Mar 21, 2024

henryZrncik commented Mar 22, 2024

[ST] default builders for plain/tls internal clients #9658

[ST] default builders for plain/tls internal clients #9658

Conversation

henryZrncik commented Feb 8, 2024 • edited

Type of change

Description

TestConstants and TestStorage

ClientUtils

<specific>ST classes

see-quick commented Feb 8, 2024

azure-pipelines bot commented Feb 8, 2024

im-konge left a comment

Choose a reason for hiding this comment

im-konge commented Feb 27, 2024

azure-pipelines bot commented Feb 27, 2024

henryZrncik commented Feb 28, 2024

strimzi-ci commented Feb 28, 2024

strimzi-ci commented Feb 28, 2024

✔️ Test Summary ✔️

henryZrncik commented Feb 29, 2024

strimzi-ci commented Feb 29, 2024

strimzi-ci commented Mar 1, 2024

❌ Test Summary ❌

❗ Test Failures ❗

henryZrncik commented Mar 4, 2024

strimzi-ci commented Mar 4, 2024

strimzi-ci commented Mar 5, 2024

❌ Test Summary ❌

❗ Test Failures ❗

see-quick commented Mar 6, 2024

azure-pipelines bot commented Mar 6, 2024

see-quick commented Mar 6, 2024

azure-pipelines bot commented Mar 6, 2024

henryZrncik commented Mar 7, 2024

strimzi-ci commented Mar 7, 2024

strimzi-ci commented Mar 7, 2024

❌ Test Summary ❌

❗ Test Failures ❗

azure-pipelines bot commented Mar 20, 2024

see-quick commented Mar 21, 2024

azure-pipelines bot commented Mar 21, 2024

henryZrncik commented Mar 22, 2024

henryZrncik commented Feb 8, 2024 •

edited

`TestConstants` and `TestStorage`

`ClientUtils`

`<specific>ST` classes