Use Integer instead of int in KafkaClusterSpec replicas
#9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
scholzj
reviewed
Feb 9, 2024
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaClusterCreator.java
Outdated
Show resolved
Hide resolved
scholzj
reviewed
Feb 9, 2024
...ator/src/main/java/io/strimzi/operator/cluster/model/nodepools/VirtualNodePoolConverter.java
Outdated
Show resolved
Hide resolved
scholzj
reviewed
Feb 9, 2024
cluster-operator/src/test/java/io/strimzi/operator/cluster/ResourceUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
im-konge
force-pushed
the
kafka-integer
branch
from
c1c9a02
to
78c2100
Compare
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
Feb 10, 2024
|
/azp run kraft-regression |
ppatierno
approved these changes
Feb 11, 2024
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR changes the
intas a type forreplicastoInteger, so we can set it asnullwhen theKafkaBuilderfor theKafkaobject is used -> for applying using fabric8 API.It also contains few
nullchecks.Checklist