Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform about reverted scale-down or role-change in .status section #9676

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Feb 11, 2024

Type of change

  • Enhancement / new feature

Description

Currently, when we revert a scale-down or role change because the brokers are not empty, we just log warning in the log. This PR adds this also as a warning condition to the custom resource to make it easier to see from there as well.

  conditions:
  - lastTransitionTime: "2024-02-11T19:55:53.565162526Z"
    message: Reverting scale-down of KafkaNodePool aston by changing number of replicas
      to 2
    reason: ScaleDownPreventionCheck
    status: "True"
    type: Warning
  - lastTransitionTime: "2024-02-11T19:55:53.605476276Z"
    message: Reverting role change of KafkaNodePool controllers by adding the broker
      role to it
    reason: ScaleDownPreventionCheck
    status: "True"
    type: Warning
  - lastTransitionTime: "2024-02-11T19:55:55.428272506Z"
    status: "True"
    type: Ready

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.40.0 milestone Feb 11, 2024
@scholzj
Copy link
Member Author

scholzj commented Feb 11, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Feb 12, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit 764de7a into strimzi:main Feb 14, 2024
29 checks passed
@scholzj scholzj deleted the inform-about-the-reverted-scale-down-in-warning-conditions branch February 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants