Reflect the current roles when rolling Kafka nodes in KafkaRoller #9686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
force-pushed
the
reflect-the-current-roles-when-rolling-the-pods-in-KafkaRoller
branch
from
3861b0d
to
4755bcd
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…loses strimzi#9434 Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
force-pushed
the
reflect-the-current-roles-when-rolling-the-pods-in-KafkaRoller
branch
from
4755bcd
to
22a60c5
Compare
scholzj
requested review from
PaulRMellor,
ppatierno,
tinaselenge and
katheris
tinaselenge
reviewed
Feb 15, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Outdated
Show resolved
Hide resolved
...er-operator/src/test/java/io/strimzi/operator/cluster/operator/resource/KafkaRollerTest.java
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-joining-node-pool-roles.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-joining-node-pool-roles.adoc
Outdated
Show resolved
Hide resolved
ppatierno
reviewed
Feb 15, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/resource/KafkaRoller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
ppatierno
approved these changes
Feb 15, 2024
PaulRMellor
approved these changes
Feb 15, 2024
documentation/modules/configuring/con-config-node-pool-roles.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-joining-node-pool-roles.adoc
Outdated
Show resolved
Hide resolved
fvaleri
reviewed
Feb 15, 2024
documentation/modules/configuring/proc-joining-node-pool-roles.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
tinaselenge
approved these changes
Feb 15, 2024
katheris
approved these changes
Feb 15, 2024
fvaleri
approved these changes
Feb 15, 2024
scholzj
deleted the
reflect-the-current-roles-when-rolling-the-pods-in-KafkaRoller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR updates the KafkaRoller to roll the Kafka nodes based on their current roles and not based on the desired roles. The current roles are taken from the Pod labels. If the pod or the annotation is missing, we assume that the role did not change and use the desired roles (this is what is done today all the time). This fix improves the transitions between architectures and enables moving from dedicated controller nodes to mixed nodes by adding the broker role to the controller nodes. Additional testing will be done in system tests in a separate PR.
This should resolve #9434.
Checklist