[ST] Use ThreadLocal in ResourceManager #9687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test --labels acceptance |
|
/packit test --labels regression |
|
/packit test --labels regression |
Signed-off-by: David Kornel <kornys@outlook.com>
|
/packit test --labels regression |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Feb 15, 2024
im-konge
approved these changes
Feb 15, 2024
henryZrncik
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Currently due to parallelism of tests every method for creating and work with resources has to pass junit extension context which is overkill and I would say no new developer understand it.
Instead of passing extension context for identifying test context in parallel run, I added ThreadLocal which can hold extenstion context for every thread in which test is running. With this change test suite itself set enxtensionContext of the test Method or Class and test developer does not need to pass extenstion context in methods so code looks more logical and clean.
Checklist