Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fix bridge client network policies creation #9719

Merged
merged 1 commit into from Mar 4, 2024

Conversation

jankalinic
Copy link
Contributor

@jankalinic jankalinic commented Feb 20, 2024

Type of change

  • Refactoring

Description

This pull request addresses the system test failure for Kafka bridge clients caused by the enabled default denial of network accessibility. The fix introduces network policy creation methods specific to the bridge client which is being deployed, enabling communication required for system testing.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@see-quick
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --testcase=HttpBridgeST,HttpBridgeScramShaST,HttpBridgeTlsST,HttpBridgeKafkaExternalListenersST --env=STRIMZI_KRAFT_ENABLED=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: HttpBridgeST,HttpBridgeScramShaST,HttpBridgeTlsST,HttpBridgeKafkaExternalListenersST
TOTAL: 12
PASS: 12
FAIL: 0
SKIP: 0
BUILD_NUMBER: 6
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_KRAFT_ENABLED=true

@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --testcase=MetricsST,OauthTlsST,OauthPlainST,OauthPasswordGrantsST --env=STRIMZI_KRAFT_ENABLED=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE: MetricsST,OauthTlsST,OauthPlainST,OauthPasswordGrantsST
TOTAL: 14
PASS: 10
FAIL: 4
SKIP: 0
BUILD_NUMBER: 7
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_KRAFT_ENABLED=true

❗ Test Failures ❗

  • testKafkaBridgeMetrics in io.strimzi.systemtest.metrics.MetricsST
  • io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST
  • io.strimzi.systemtest.security.oauth.OauthPlainST
  • io.strimzi.systemtest.security.oauth.OauthTlsST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.metrics.MetricsST#testKafkaBridgeMetrics,io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST,io.strimzi.systemtest.security.oauth.OauthPlainST,io.strimzi.systemtest.security.oauth.OauthTlsST

Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic
Copy link
Contributor Author

re-requesting reviews due to changes being made for metrics ST, where scraper could not access bridge

@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --testcase=MetricsST,OauthTlsST,OauthPlainST,OauthPasswordGrantsST --env=STRIMZI_KRAFT_ENABLED=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE: MetricsST,OauthTlsST,OauthPlainST,OauthPasswordGrantsST
TOTAL: 14
PASS: 11
FAIL: 3
SKIP: 0
BUILD_NUMBER: 11
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_KRAFT_ENABLED=true

❗ Test Failures ❗

  • io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST
  • io.strimzi.systemtest.security.oauth.OauthPlainST
  • io.strimzi.systemtest.security.oauth.OauthTlsST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.security.oauth.OauthPasswordGrantsST,io.strimzi.systemtest.security.oauth.OauthPlainST,io.strimzi.systemtest.security.oauth.OauthTlsST

@jankalinic
Copy link
Contributor Author

3 failing tests - all because of keycloak setup - not related to this PR

@im-konge im-konge merged commit 1d5a388 into strimzi:main Mar 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants