Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] persistent kafka with 1 rep. instead ephemeral #9782

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

henryZrncik
Copy link
Contributor

@henryZrncik henryZrncik commented Mar 5, 2024

Type of change

  • Refactoring

Description

stop using ephemeral kafka with 1 replica and use either persistent storage or more replicas.

Fixes #9748

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik henryZrncik marked this pull request as draft March 5, 2024 23:00
@henryZrncik
Copy link
Contributor Author

@strimzi-ci run tests --profile=all --env=STRIMZI_FEATURE_GATES=-KafkaNodePools,-UnidirectionalTopicOperator,-UseKRaft

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@see-quick
Copy link
Member

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik henryZrncik added this to the 0.40.0 milestone Mar 6, 2024
@henryZrncik henryZrncik self-assigned this Mar 6, 2024
@henryZrncik henryZrncik marked this pull request as ready for review March 7, 2024 09:51
@see-quick
Copy link
Member

see-quick commented Mar 7, 2024

Adding 2 more ZK nodes into STs could cause that our memory limit for current VMs, which we have can be reached. So I would be very careful (we can run regression pipeline more than 1 time to prove that it's okay).

I think having some kind of probe to monitor memory/cpu usage would be good for this inside our STs

@see-quick
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik
Copy link
Contributor Author

@see-quick yeah good suggestion, I have tried to avoid this solution in test case where more than 1 kafka is created, but still i wanted to create this situation at least in 2,3 tests to see if it it would really cause some resources problem as i did not hit this problem locally or in past.

…kafka clusters used

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --testcase=HttpBridgeST,MirrorMaker2ST,RackAwarenessST --parallel-count=1 --env=STRIMZI_FEATURE_GATES=+UnidirectionalTopicOperator;STRIMZI_USE_KRAFT_IN_TESTS=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@im-konge
Copy link
Member

im-konge commented Mar 7, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: HttpBridgeST,MirrorMaker2ST,RackAwarenessST
TOTAL: 22
PASS: 22
FAIL: 0
SKIP: 0
BUILD_NUMBER: 34
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 1
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_FEATURE_GATES=+UnidirectionalTopicOperator;STRIMZI_USE_KRAFT_IN_TESTS=true

Signed-off-by: hzrncik <hzrncik@redhat.com>
@scholzj scholzj modified the milestones: 0.40.0, 0.41.0 Mar 8, 2024
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@im-konge
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…afkas created in tests

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik henryZrncik added ready for merge Label for PRs which are ready for merge and removed needs review labels Mar 11, 2024
@im-konge im-konge removed the ready for merge Label for PRs which are ready for merge label Mar 11, 2024
@im-konge
Copy link
Member

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit e28f585 into strimzi:main Mar 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use single replica nodes with ephemeral storage in System Tests
5 participants