Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cruise control): employing cruise control to change topic replication factor #9788

Merged
merged 3 commits into from
Mar 13, 2024
Merged

docs(cruise control): employing cruise control to change topic replication factor #9788

merged 3 commits into from
Mar 13, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Mar 6, 2024 •
edited

Documentation

Adds a procedure to describe how to use the UTO + Cruise Control to change the topic replication factor form a configuration update to the KafkaTopic resource.
Also includes some updates for out-of-date content related to using the partition reassignment tool

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor
docs(cruise control): employing cruise control to change topic replic…
974f99a 
…ation factor

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor PaulRMellor added this to the 0.40.0 milestone Mar 6, 2024
@PaulRMellor PaulRMellor self-assigned this Mar 6, 2024
scholzj
scholzj reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits ...

documentation/assemblies/configuring/assembly-reassign-tool.adoc Outdated Show resolved Hide resolved
documentation/modules/cruise-control/proc-cruise-control-topic-replication.adoc Outdated Show resolved Hide resolved
documentation/modules/cruise-control/proc-cruise-control-topic-replication.adoc Show resolved Hide resolved
documentation/modules/cruise-control/proc-cruise-control-topic-replication.adoc Outdated Show resolved Hide resolved
fvaleri
fvaleri reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, apart from the few outstanding comments.

@PaulRMellor
docs(review): edits to doc from comments by JS - 01
dd19590 
Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor
docs(review): edits to doc from comments by PP -- 01
aadf0cd 
Signed-off-by: prmellor <pmellor@redhat.com>
fvaleri
fvaleri approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@scholzj scholzj modified the milestones: 0.40.0, 0.41.0 Mar 8, 2024
@PaulRMellor PaulRMellor merged commit 6f79f2a into strimzi:main Mar 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@fvaleri fvaleri fvaleri approved these changes

Assignees

@PaulRMellor PaulRMellor

Labels
documentation
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PaulRMellor @scholzj @ppatierno @fvaleri