Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kafka): expands the content for handling large message sizes #9790

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Mar 6, 2024

Documentation

Expands the content related to handling large message sizes.
Changes the order based on recommended approach.
Includes config examples for brokers, producers, and consumers, as well as config for the producers and consumers of other components.
Moves the content into a separate section, as the config is not isolated to brokers.

Please describe your pull request

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor PaulRMellor added this to the 0.40.0 milestone Mar 6, 2024
@PaulRMellor PaulRMellor self-assigned this Mar 6, 2024
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left just a nit and agree with Jakub's comments.

Copy link
Contributor

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj modified the milestones: 0.40.0, 0.41.0 Mar 8, 2024
Signed-off-by: prmellor <pmellor@redhat.com>
@scholzj scholzj merged commit 6845d95 into strimzi:main Mar 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants