Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Add NetworkPolicies for OpenTelemetryST when running on OCP #9793

Merged
merged 1 commit into from Mar 7, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Mar 6, 2024

Type of change

  • Bugfix

Description

This PR fixes not working OpenTelemetryST on OCP, where we are enabling "default to deny" NetworkPolicies for all testcases.
It adds new generic NetworkPolicy related methods to NetworkPolicyResource, which can be useful also for different testcases and uses it in the Oauth as well.

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge requested a review from a team March 6, 2024 21:17
@im-konge im-konge self-assigned this Mar 6, 2024
@im-konge im-konge added this to the 0.40.0 milestone Mar 6, 2024
@im-konge
Copy link
Member Author

im-konge commented Mar 6, 2024

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --groups=oauth,tracing

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@im-konge
Copy link
Member Author

im-konge commented Mar 6, 2024

@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --groups=oauth

@im-konge
Copy link
Member Author

im-konge commented Mar 6, 2024

@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --groups=tracing

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

1 similar comment
@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS: tracing
TEST_CASE:
TOTAL: 6
PASS: 6
FAIL: 0
SKIP: 0
BUILD_NUMBER: 29
OCP_VERSION: stable
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 1
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS: oauth,tracing
TEST_CASE:
TOTAL: 35
PASS: 35
FAIL: 0
SKIP: 0
BUILD_NUMBER: 27
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

Copy link
Contributor

@jankalinic jankalinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like generally good approach.

@im-konge im-konge merged commit 7058ee2 into strimzi:main Mar 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants