Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fixups for few failing tests in nightlies #9801

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Mar 8, 2024

Type of change

  • Bugfix

Description

This PR fixes few failing tests in our nightlies, mainly for OCP:

  • tests that are using route as a listener types are sometimes failing on the length of the hostname - that is hit because of long name of the NodePools. I changed it from broker-, control-, and mixed- prefixes to b-, c-, m- prefixes. In case that it will not be that readable, we can try different prefix and possibly shorter the suffix as well.
  • changed my-cluster- prefix to cluster-
  • added ROUTE tag to one test missing this tag
  • created SkipDefaultNetworkPolicyCreation for tests that need skip of creation of the default NetworkPolicies -> for example test testNPGenerationEnvironmentVariable turns off creation of NetworkPolicies in CO -> and because the "default to deny" global network policy we would not be able to create the Kafka Pods, as it seems that the ZooKeeper throws "connection refused", but in the end it's just the default NetworkPolicies that blocks the connection requests to ZK
  • added missing NP creation to HTTP CORS tests and MultipleClusterOperatorsST

Checklist

  • Make sure all tests pass

…ing creation of default NP for some tests

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.40.0 milestone Mar 8, 2024
@im-konge im-konge self-assigned this Mar 8, 2024
@im-konge im-konge requested a review from a team March 8, 2024 08:05
Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fix. Works for me ✅

@im-konge
Copy link
Member Author

im-konge commented Mar 8, 2024

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --groups=route,bridge,networkpolicies

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

im-konge commented Mar 8, 2024

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --groups=route,bridge,networkpolicies

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@im-konge
Copy link
Member Author

im-konge commented Mar 8, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Mar 8, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS: route,bridge,networkpolicies
TEST_CASE:
TOTAL: 30
PASS: 30
FAIL: 0
SKIP: 0
BUILD_NUMBER: 36
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@scholzj scholzj modified the milestones: 0.40.0, 0.41.0 Mar 8, 2024
@im-konge
Copy link
Member Author

im-konge commented Mar 8, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit 8fe5d3d into strimzi:main Mar 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants