Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fix and improve migration docs #9804

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[DOC] Fix and improve migration docs #9804

merged 2 commits into from
Mar 11, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 9, 2024

Type of change

  • Bugfix
  • Documentation

Description

This PR does some fixes and improvements to the docs related to the KRaft migration.

  • It fixes the misformatted annotations
  • It adds a sub-chapter for the rollback to make it easier to link to it
  • It clarifies what should be removed in the Kafka CR once the migration id complete

Checklist

  • Update documentation

@scholzj
[DOC] Fix and improve migration docs
c1b0cce 
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Mar 9, 2024
ppatierno
ppatierno approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left just a nit.

documentation/modules/deploying/proc-deploy-migrate-kraft.adoc Outdated Show resolved Hide resolved
@scholzj
Review comments PP
99788f7 
Signed-off-by: Jakub Scholz <www@scholzj.com>
PaulRMellor
PaulRMellor approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@scholzj scholzj merged commit 2b6d650 into strimzi:main Mar 11, 2024
13 checks passed
@scholzj scholzj deleted the docs-fix-and-improve-the-migration-docs branch March 11, 2024 15:02
scholzj added a commit that referenced this pull request Mar 13, 2024
@scholzj
[DOC] Fix and improve migration docs (#9804)
b5f93e9 
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno approved these changes

@PaulRMellor PaulRMellor PaulRMellor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scholzj @ppatierno @PaulRMellor