Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fix the issue with creating Kafka in CC tests in KRaft mode with lower Kafka version #9808

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Mar 11, 2024

Type of change

  • Bugfix

Description

This PR fixes the issue described in #9805 where the Kafka with CC is not deployable because of the wrong version in inter.broker.protocol.version.
The issue is resolved by removing the LMFV and IBPV from the config, in case that we are running in KRaft mode.

Also this PR resolves one "TODO" inside the CruiseControlST

Fixes #9805

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.41.0 milestone Mar 11, 2024
@im-konge im-konge requested review from scholzj and a team March 11, 2024 10:18
@im-konge im-konge self-assigned this Mar 11, 2024
@im-konge
Copy link
Member Author

@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --groups=cruisecontrol --env=ST_KAFKA_VERSION=3.6.0;STRIMZI_USE_KRAFT_IN_TESTS=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@im-konge
Copy link
Member Author

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

1 similar comment
@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS: cruisecontrol
TEST_CASE:
TOTAL: 42
PASS: 42
FAIL: 0
SKIP: 0
BUILD_NUMBER: 41
OCP_VERSION: stable
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 1
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: ST_KAFKA_VERSION=3.6.0;STRIMZI_USE_KRAFT_IN_TESTS=true

@im-konge im-konge merged commit 4ff668d into strimzi:main Mar 12, 2024
22 checks passed
@im-konge im-konge deleted the fix-cc-kraft branch March 12, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cruise Control STs are failing with older Kafka versions when KRaft is used
5 participants