#9734 - added toString to whole model, including Password, PasswordSe… #9810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
reviewed
Mar 11, 2024
There was a problem hiding this comment.
It looks like the scope of the dependnecies changed:
[INFO] --- maven-dependency-plugin:3.3.0:analyze-only (analyze) @ api ---
[WARNING] Unused declared dependencies found:
[WARNING] com.fasterxml.jackson.core:jackson-core:jar:2.16.1:compile
[WARNING] Non-test scoped test only dependencies found:
[WARNING] com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.16.1:compile
Can you please update the api/pom.xml accordingly?
…swordSecretSource and PasswordSource classes Signed-off-by: Slavomir Kocka <slavomir.kocka@gmail.com>
…ml, to be only in test scole Signed-off-by: Slavomir Kocka <slavomir.kocka@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cretSource and PasswordSource classes
Type of change
Description
Implementation of the issue #9734
All classes in the model package and sub-packages now contain toString generated by Lombok's
@ToString.Additionally:
@EqualsAndHashCode@EqualsAndHashCodeand@ToStringare usingcallSuper=truePassword,PasswordSecretSource,PasswordSourceas they in fact do not contain secretsKubernetesVersionis left intact with manual hashCode, equals, and toString