-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote KafkaNodePools
feature gate to GA
#9811
Promote KafkaNodePools
feature gate to GA
#9811
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run kraft-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One suggestion for doc consistency
documentation/modules/operators/ref-operator-cluster-feature-gates.adoc
Outdated
Show resolved
Hide resolved
…ates.adoc Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Jakub Scholz <www@scholzj.com>
Type of change
Description
This PR promotes the
KafkaNodePools
feature gate to GA and basically removes it. The use of node pools is still gated by the annotation on theKafka
CR. This PR also updates the docs and the system tests. As we cannot disable the feature gate anymore, it adds a new environment variable to drive when the node pools are used and when they are not used with the intention to use them inregression
andkraft-regression
and not use them infeature-gates-regression
.Checklist