Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote KafkaNodePools feature gate to GA #9811

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 11, 2024

Type of change

  • Task

Description

This PR promotes the KafkaNodePools feature gate to GA and basically removes it. The use of node pools is still gated by the annotation on the Kafka CR. This PR also updates the docs and the system tests. As we cannot disable the feature gate anymore, it adds a new environment variable to drive when the node pools are used and when they are not used with the intention to use them in regression and kraft-regression and not use them in feature-gates-regression.

Checklist

  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Mar 11, 2024
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@scholzj
Copy link
Member Author

scholzj commented Mar 11, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@scholzj
Copy link
Member Author

scholzj commented Mar 12, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj
Copy link
Member Author

scholzj commented Mar 12, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Mar 12, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion for doc consistency

…ates.adoc

Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit 055179d into strimzi:main Mar 12, 2024
13 checks passed
@scholzj scholzj deleted the promote-KafkaNodePools-feature-gate-to-GA branch March 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants