You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes#9754
with correct broker Pod name. But during the work on the fix I found out that the QuotasST doesn't work at all:
the test-clients were running out of memory on local clusters
the ST doesn't work on clusters with local storage (e.g. minikube), which makes sense in terms of the calculation of the used storage
the check for disk is beyond soft limit is flaky, as we can hit the soft limit really rarely, based on how the messages are send and how much free (or filled) storage we have during the test execution
we are not running the test in any pipeline and it doesn't contain any tag for easier execution
there is no note about "how we can actually run the test"
This PR should fix all of the above, it adds new tag quotasplugin for easier execution of the ST class, adds new method isMinikube, so it will be skipped on minikube clusters, and more.
LGTM, just about execution is QUOTAS_PLUGIN to be executed as part of something else? I am asking to know if this test will be run periodically, or just as a group (which you called in strimzi-ci) ?
No, I don't expect to execute the quotasplugin group anywhere in the regression (in AZP for example) - as I mentioned, the test will not work on minikube
So it should be executed on some weekly bases on some normal cluster.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes #9754
with correct broker Pod name. But during the work on the fix I found out that the
QuotasSTdoesn't work at all:minikube), which makes sense in terms of the calculation of the used storagedisk is beyond soft limitis flaky, as we can hit the soft limit really rarely, based on how the messages are send and how much free (or filled) storage we have during the test executionThis PR should fix all of the above, it adds new tag
quotaspluginfor easier execution of the ST class, adds new methodisMinikube, so it will be skipped onminikubeclusters, and more.Fixes #9754
Checklist