Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value for all topics and groups selected in Strimzi Kafka Exporter dashboard #9817

Merged

Conversation

maciej-tatarski
Copy link
Contributor

Type of change

  • Bugfix

Description

Related to: #9537

With big number of topics and consumer groups, the Kafka Exporter Grafana Dashboard does not work because the API call being executed behind the panels is too long. Instead of including all topics name in api call, we'll now substitute all value with .* regex which will have the same result.

image

Tested with grafana 7.5.7, v10.3.3

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: maciej-tatarski <maciej.tatarski@maersk.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you please do the changes only in the /packaging/... folders? The /install and /examples folders are updated only as part of a release.

@scholzj scholzj added this to the 0.41.0 milestone Mar 12, 2024
Signed-off-by: maciej-tatarski <maciej.tatarski@maersk.com>
@maciej-tatarski
Copy link
Contributor Author

maciej-tatarski commented Mar 12, 2024

I reverted the changes for release files

@scholzj scholzj requested a review from ppatierno March 12, 2024 15:16
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@scholzj scholzj linked an issue Mar 12, 2024 that may be closed by this pull request
@scholzj scholzj merged commit cbae4d4 into strimzi:main Mar 13, 2024
13 checks passed
@maciej-tatarski maciej-tatarski deleted the 9537-grafana-kafka-exporter-url-bug branch March 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Kafka Exporter Grafana dashboard too long URL error
3 participants