Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Enhance DrainCleanerST #9829

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Mar 13, 2024

Type of change

  • Enhancement

Description

This PR enhances the DrainCleanerST with following:

  • moves the test from ACCEPTANCE to REGRESSION
  • evicts just one Pod of kind Kafka or ZK
  • lower the number of messages
  • uses correct installation files folder (kubernetes/openshift) based on cluster type
  • cleans the whole test a bit
  • fixes NetworkPolicy for webhook in case of OCP

Additionally, it adds new method isOpenShiftLikeCluster() to KubeClusterResource, which is useful in case that we want to determine, if the cluster is "OpenShift-like" -> in our case OpenShift or MicroShift.

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge self-assigned this Mar 13, 2024
@im-konge im-konge added this to the 0.41.0 milestone Mar 13, 2024
@im-konge im-konge requested review from scholzj and a team March 13, 2024 10:23
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! thanks.

@im-konge
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --testcase=DrainCleanerST

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: DrainCleanerST
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 43
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@im-konge
Copy link
Member Author

@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --testcase=DrainCleanerST --env=STRIMZI_USE_KRAFT_IN_TESTS=true

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: DrainCleanerST
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 45
OCP_VERSION: stable
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 1
EXCLUDED_GROUPS: loadbalancer,nodeport,olm
ENV_VARIABLES: STRIMZI_USE_KRAFT_IN_TESTS=true

@im-konge im-konge merged commit d683111 into strimzi:main Mar 13, 2024
22 checks passed
@im-konge im-konge deleted the enhance-drain-cleaner branch April 4, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants