Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chart to table for log size #9830

Merged

Conversation

maciej-tatarski
Copy link
Contributor

Type of change

  • Enhancement

Description

Changing type of the chart for Log Size to Table, which can be filtered and sorted.

Tested with grafana 7.3.7, 7.5.7 and 10.3.4. Discoussed in #7374.

image

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: maciej-tatarski <maciej.tatarski@maersk.com>
@maciej-tatarski maciej-tatarski force-pushed the 7374-improve-strimzi-kafka-dashboard branch from 080d55d to 4fd56fc Compare March 13, 2024 12:05
@scholzj scholzj added this to the 0.41.0 milestone Mar 13, 2024
@scholzj scholzj requested a review from ppatierno March 13, 2024 13:40
@scholzj scholzj linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR!

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scholzj scholzj merged commit 5b773ff into strimzi:main Mar 14, 2024
13 checks passed
@maciej-tatarski maciej-tatarski deleted the 7374-improve-strimzi-kafka-dashboard branch March 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Kafka brokers Grafana dashboard
3 participants