[ST] KafkaConnect dynamic log level change test checks addition #9834
Conversation
Signed-off-by: hzrncik <hzrncik@redhat.com>
|
@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --testcase=LoggingChangeST#testDynamicallySetConnectLoggingLevels |
|
|
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java
Outdated
Show resolved
Hide resolved
✔️ Test Summary ✔️TEST_PROFILE: all |
…billity Signed-off-by: hzrncik <hzrncik@redhat.com>
There was a problem hiding this comment.
@henryZrncik LGTM. Thanks.
Only left some minor improvements for you to consider.
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java
Outdated
Show resolved
Hide resolved
…hange, some minor style fixes Signed-off-by: hzrncik <hzrncik@redhat.com>
|
@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --install-type=bundle --profile=all --testcase=LoggingChangeST#testDynamicallySetConnectLoggingLevels |
|
|
✔️ Test Summary ✔️TEST_PROFILE: all |
henryZrncik
added
ready for merge
…mzi#9834) Signed-off-by: hzrncik <hzrncik@redhat.com> Signed-off-by: Steffen Karlsson <steffen.karlsson@maersk.com>
Type of change
Description
testDynamicallySetConnectLoggingLevelsformerly created single Connect Pod, adding more replicas and checking changes of log level on all of them can cover more optional problems which may occur in situation such as #9067there is also addition of changing log level from DEBUG to INFO and extension of checking log for last 60 seconds instead of 30 which in some situation hardly touched the actual change (This does not mean that test execution would actively wait for that long rather few extra seconds).