Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single node KRaft example for use in quickstarts #9837

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 14, 2024

Type of change

  • Task

Description

This PR adds a new KRaft example for a single node KRaft cluster. This would be useful in the quickstarts on our website to replace the ZooKeeper which has DNS issues for some users.

It also fixes the 20Gi storage in some of the other Kraft examples - that seems a copy-paste error - and brings it in sync with our other examples where we use 100Gi.

It also updates the README file to correspond to the latest changes.

Checklist

  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Mar 14, 2024
@scholzj scholzj requested a review from ppatierno March 14, 2024 14:28
For instance, JBOD storage is not supported (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume).
To use KRaft, ensure that the and `UseKRaft` feature gate is not disabled.
Please note that ZooKeeper-less Apache Kafka is still under development and has some limitations.
For instance, scaling of controller node or JBOD storage (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume) are not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For instance, scaling of controller node or JBOD storage (you can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume) are not supported.
For instance, scaling of controller node or JBOD storage are not supported.
You can specify `type: jbod` storage in Strimzi custom resources, but it should contain only a single volume.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JBOd note belongs specifically to the JBOD storage part, so I think it is better to have it directly there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but it's kind of weird to read. What about "If you still want to use JBOD, you can specify..."

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. LGTM.

packaging/examples/kafka/kraft/README.md Outdated Show resolved Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit e70a6b2 into strimzi:main Mar 15, 2024
13 checks passed
@scholzj scholzj deleted the add-single-node-kraft-example branch March 15, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants