Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Set STRIMZI_USE_NODE_POOLS_IN_TESTS to true by default #9839

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

im-konge
Copy link
Member

Type of change

  • Enhancement

Description

When running STs locally, we are assuming that we have NodePools enabled. But currently, those are disabled by default by STRIMZI_USE_NODE_POOLS_IN_TESTS. This PR sets this env variable to true by default.

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge self-assigned this Mar 15, 2024
@im-konge im-konge added this to the 0.41.0 milestone Mar 15, 2024
@im-konge im-konge requested a review from a team March 15, 2024 11:04
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@im-konge
Copy link
Member Author

/azp list

@im-konge
Copy link
Member Author

/azp run acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

/packit test --labels=acceptance

@im-konge im-konge merged commit 372fa5d into strimzi:main Mar 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants