Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation about recommended Kubernetes labels #9854

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Added documentation about recommended Kubernetes labels #9854

merged 5 commits into from
Mar 21, 2024

Conversation

ppatierno
Copy link
Member

This PR adds some documentation around the recommended Kubernetes labels that we set on operands and cannot be overwritten by users when using templates.
This is related to #9735

@ppatierno
Added documentation about recommended Kubernetes labels
48afe52 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno added this to the 0.41.0 milestone Mar 20, 2024
@ppatierno ppatierno requested review from PaulRMellor and a team March 20, 2024 11:15
@ppatierno
Fixed asciidoc checks
f4558c0 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno
Fixed wrong formatted YAML
9ab2da2 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
PaulRMellor
PaulRMellor reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paolo. I've left some suggestions. I thought it might be better to describe the constraints earlier.

documentation/modules/configuring/ref-kubernetes-labels.adoc Outdated Show resolved Hide resolved
documentation/modules/configuring/ref-kubernetes-labels.adoc Outdated Show resolved Hide resolved
documentation/modules/configuring/ref-kubernetes-labels.adoc Outdated Show resolved Hide resolved
documentation/modules/configuring/ref-kubernetes-labels.adoc Outdated Show resolved Hide resolved
documentation/modules/configuring/ref-kubernetes-labels.adoc Outdated Show resolved Hide resolved
@PaulRMellor
Copy link
Contributor

@ppatierno -- I wonder if we should move this section to sit as a sub-section under here instead?
https://strimzi.io/docs/operators/in-development/deploying#assembly-customizing-kubernetes-resources-str

It's in the same chapter, but has content related to Kubernetes resources.

@ppatierno
Copy link
Member Author

It's in the same chapter, but has content related to Kubernetes resources.

@PaulRMellor I see your point but it's about "customizing" so still same fear like the title.

@ppatierno
Copy link
Member Author

ppatierno commented Mar 20, 2024 •
edited by PaulRMellor

@PaulRMellor I noticed your thumbs up on my latest comment about leaving the PR as it is. Are you going to approve as well? Or do you have any other comments?

Did you make any changes based on my suggestions? Don't see any?

@ppatierno
Fixed PaulRMellor comments
0bfb2f9 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
PaulRMellor
PaulRMellor approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ppatierno
Last addressed comment
edcb537 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno
Copy link
Member Author

The TopicOperatorIT test failure is not obviously related to the documentation changes. I am going to merge this.

@ppatierno ppatierno merged commit 21bdaf9 into strimzi:main Mar 21, 2024
11 of 13 checks passed
@ppatierno ppatierno deleted the add-kubernetes-labels-doc branch March 21, 2024 10:03
steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Mar 21, 2024
@ppatierno @steffen-karlsson
Added documentation about recommended Kubernetes labels (strimzi#9854)
e50d20f 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Steffen Karlsson <steffen.karlsson@maersk.com>
steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Mar 21, 2024
@ppatierno @steffen-karlsson
Added documentation about recommended Kubernetes labels (strimzi#9854)
4105077 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Steffen Karlsson <steffen.karlsson@maersk.com>
steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Apr 2, 2024
@ppatierno @steffen-karlsson
Added documentation about recommended Kubernetes labels (strimzi#9854)
7cd07dd 
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@PaulRMellor PaulRMellor PaulRMellor approved these changes

@im-konge im-konge im-konge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ppatierno @PaulRMellor @scholzj @im-konge