Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vert.x dependency from MicrometerMetricsProvider #9879

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 26, 2024

Type of change

  • Task

Description

This PR removes the Vert.x dependency from MicrometerMetricsProvider in operator-common and remove the related Maven dependency. This is now used only from the Cluster Operator module and shifting the Vert.x logic there will help to reduce the Vert.x footprint in operator-common.

Checklist

  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Mar 26, 2024
@scholzj scholzj requested a review from ppatierno March 26, 2024 17:22
@scholzj
Copy link
Member Author

scholzj commented Mar 26, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 179ad17 into strimzi:main Mar 27, 2024
21 checks passed
@scholzj scholzj deleted the remove-vertx-dependency-from-micrometer-metrics-provider branch March 27, 2024 08:52
steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Apr 2, 2024
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants