Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unrelated clases from the package with resource operators #9882

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Mar 26, 2024

Type of change

  • Bugfix

Description

The io.strimzi.operator.common.operator.resource package seems to contain several classes that do not seem to be directly related to the Kubernetes resource operators:

  • TimeoutException is used by some of the Kubernetes resource operators classes, but is also used by many other classes outside of it such as ZooKeeper clients, ZooKeeepr Eraser, Kafka Roller and so on -> so it makes sense to have it a more general package. I moved it directly to io.strimzi.operator.common.
  • ConfigParameter and ConfigParameterParser are used for configuration of our operators and have nothing to do with the Kubernetes Resource Operators. It is not clear why are they in this package. I moved them to a new package io.strimzi.operator.common.config.

Checklist

  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Mar 26, 2024
@scholzj scholzj requested a review from ppatierno March 26, 2024 20:19
@scholzj
Copy link
Member Author

scholzj commented Mar 26, 2024

/azp run acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj
Copy link
Member Author

scholzj commented Mar 27, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit a13058f into strimzi:main Mar 27, 2024
21 checks passed
@scholzj scholzj deleted the move-unrelated-classes-out-of-the-resource-operators-package branch March 27, 2024 14:47
steffen-karlsson pushed a commit to steffen-karlsson/strimzi-kafka-operator that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants