Remove Vert.x dependency from the operator-common module and from UO and TO
#9887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and TO Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
changed the title
operator-common module and from UO and TO
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Mar 27, 2024
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Mar 28, 2024
steffen-karlsson
pushed a commit
to steffen-karlsson/strimzi-kafka-operator
that referenced
this pull request
Apr 2, 2024
…O and TO (strimzi#9887) Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
After the removal of the BTO, Vert.x is no used only int he Cluster Operator. This PR moves the Vert.x based Kubernetes Resource Operators to the
cluster-operatormodule together with theVertxUtilsclass. These were the last Vert.x based classes in theoperator-commonmodule. So this frees it from the dependency on Vert.x and stops pulling VErt.x also into the UO and TO.Most of the changes in this PR are just moved classes and changed imports. The Kubernetes resource operators were moved to a new
kubernetessubpackage since theresourceoperators package in the Cluster OPerator is already full of various Kafka and ZooKeeper stuff, so having a separate package provides better separation. The configuration of the Vert.x cache directory was also moved to be set only in the CO startup shell script.Checklist