Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing ReconcileResult with type parameter, instead of checking toString #9891

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

steffen-karlsson
Copy link
Contributor

Type of change

  • Refactoring

Description

Enhancing ReconcileResult with type parameter, instead of checking toString.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

…String.

Signed-off-by: Steffen Karlsson <steffen.karlsson@maersk.com>
@steffen-karlsson
Copy link
Contributor Author

As agreed on @scholzj :)

@scholzj scholzj added this to the 0.41.0 milestone Mar 28, 2024
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@scholzj
Copy link
Member

scholzj commented Mar 28, 2024

/azp run regression

@scholzj scholzj requested a review from ppatierno March 28, 2024 13:30
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ppatierno ppatierno merged commit 059500c into strimzi:main Mar 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants