Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pom refactoring on OpenTelemetry related dependencies #9892

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

ppatierno
Copy link
Member

This PR is similar to what is done on the bridge with strimzi/strimzi-kafka-bridge#891

  • avoid using a otel version property as variable to declare otel alpha version. OpenTelemetry is moving to deliver different artifacts at difference pace, also some of them will be non alpha at some point. It's better having the explicit version then.
  • because guava "jre" is already a direct dependency, it just add an explicit exclusion from the corresponding "androd" from otel and grpc dependencies (NOTE: it's already happening implicitly, but I think it's better having it explicitly for clarity).

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno added this to the 0.41.0 milestone Mar 28, 2024
@ppatierno ppatierno requested a review from a team March 28, 2024 15:06
Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppatierno ppatierno merged commit 9274135 into strimzi:main Mar 29, 2024
21 checks passed
@ppatierno ppatierno deleted the otel-dependencies-refactoring branch March 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants