Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roles column definition for the KafkaNodePool CRD #9896

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

ppatierno
Copy link
Member

Trivial PR to add the ROLES column definition to the KafkaNodePool CRD.
Using the string type from the possible ones from OpenAPI seems to be the way to print the list of roles.

NAME         DESIRED REPLICAS   ROLES
controller   3                  ["controller"]
kafka        3                  ["broker"]

and

NAME        DESIRED REPLICAS   ROLES
dual-role   3                  ["controller","broker"]

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno requested a review from a team March 29, 2024 10:19
@ppatierno ppatierno added this to the 0.41.0 milestone Mar 29, 2024
@ppatierno ppatierno requested a review from scholzj March 29, 2024 10:19
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful. Thanks.

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno merged commit 7901813 into strimzi:main Mar 29, 2024
13 checks passed
@ppatierno ppatierno deleted the add-roles-crd-column-definition branch March 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants