Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect path in custom authorizer docs and improve them #9920

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 4, 2024

Type of change

  • Bugfix

Description

This PR fixed an incorrect path to the 3rd party libs that changed since the docs were written. It also does some additional improvements:

  • Adds an option to add the file using a Dockerfile
  • Tries to create a better structure to the chapter that seems to mix subchapters followed by a general content

Checklist

  • Update documentation

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Apr 4, 2024
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved. I left a few minor suggestions.

@PaulRMellor PaulRMellor changed the title Fix incorrect path in custom authroizer docs and improve them Fix incorrect path in custom authorizer docs and improve them Apr 5, 2024
scholzj and others added 2 commits April 5, 2024 20:13
Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit d89a314 into strimzi:main Apr 5, 2024
13 checks passed
@scholzj scholzj deleted the docs-fix-the-third-party-libs-path branch April 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants