Fix paused connector status when Connect is scaled to zero #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common strategy across operators is that a paused resource should overwrite any error in terms of status update. This is currently not happening when a connector is paused after Connect is scaled to zero. The connector is first updated to `NotReady` by `connectorEventHandler`, and then `ReconciliationPaused` by `reconcileConnectors`. The `testConnectorResourceMetricsScaledToZero` fails randmonly because of this double status update. Besides, the test is wrong, as it does not expect the connector to be paused. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
scholzj
reviewed
Apr 7, 2024
...rc/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaConnectAssemblyOperator.java
Show resolved
Hide resolved
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common strategy across operators is that a paused resource should overwrite any error in terms of status update. This is currently not happening when a connector is paused after Connect is scaled to zero.
The connector is first updated to
NotReadybyconnectorEventHandler, and thenReconciliationPausedbyreconcileConnectors. ThetestConnectorResourceMetricsScaledToZerofails randmonly because of this double status update. Besides, the test is wrong, as it does not expect the connector to be paused.This should fix #9843.