Fixed validation minimum Kafka version for migration #9935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Patierno <ppatierno@live.com>
scholzj
approved these changes
Apr 9, 2024
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
approved these changes
Apr 9, 2024
fvaleri
approved these changes
Apr 9, 2024
Refactored other tests to use 3.7.0 as the minimum Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
The migration pipeline I started before the last commit is green (even if not visible here anymore) so we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial PR to fix the minimum Kafka version to validate the possibility of migrating the cluster to KRaft.
We were aiming for 3.7.0 as the minimum (as by the comments) but current code was leveraging the default
MetadataVersion.isMigrationSupported()method which is validating against 3.4.0 (it just doesreturn this.isAtLeast(IBP_3_4_IV0);).