Removing the inner polling to check proposal request and rebalancing #9940
Conversation
|
@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --groups=cruisecontrol |
|
|
❌ Test Summary ❌TEST_PROFILE: all ❗ Test Failures ❗
Re-run command: |
|
@strimzi-ci run tests --cluster-type=minikube --cluster-version=stable --install-type=bundle --profile=all --groups=cruisecontrol --build-images |
|
|
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Refactoring rebalancing related tests now relying on reconciliation loop Signed-off-by: Paolo Patierno <ppatierno@live.com>
ppatierno
force-pushed
the
remove-rebalance-periodic-timer
branch
from
06e059a
to
8f746cb
Compare
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Refactored tests by calling the main reconcile entry point on the KafkaRebalanceAssemblyOperator Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
...t/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Thanks for refactoring this @ppatierno, looks a lot cleaner!
Type of change
Description
This PR removes the inner polling loop when checking the status of a rebalance proposal request and the current rebalancing. It refactors the code in order to rely on the operator periodic reconcile loop to run the checks.
Due to this change, the PR has a big refactoring on tests as well because of the logic is now depending on the reconciliation loop and not hidden inside a short periodic internal polling anymore.
Checklist
Please go through this checklist and make sure all applicable tasks have been done