Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for Label.class related to label filtering #9959

Merged
merged 12 commits into from
Apr 17, 2024
Merged

Add more unit tests for Label.class related to label filtering #9959

merged 12 commits into from
Apr 17, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Apr 15, 2024 •
edited

Type of change

  • Enhancement / new feature

Description

This PR adds more unit tests for Label.class to filter labels in all resources (e.g., Kafka, KafkaUser...).

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@see-quick see-quick added this to the 0.41.0 milestone Apr 15, 2024
@see-quick see-quick self-assigned this Apr 15, 2024
@see-quick see-quick marked this pull request as ready for review April 15, 2024 07:25
@see-quick see-quick requested a review from a team April 15, 2024 07:25
scholzj
scholzj reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. But I think you should consider how STRIMZI_LABELS_EXCLUSION_PATTERN inthe Labels class is used and try to apply a similar pattern for both.

user-operator/src/main/java/io/strimzi/operator/user/UserOperatorConfig.java Outdated Show resolved Hide resolved
user-operator/src/main/java/io/strimzi/operator/user/model/KafkaUserModel.java Outdated Show resolved Hide resolved
user-operator/src/main/java/io/strimzi/operator/user/model/KafkaUserModel.java Outdated Show resolved Hide resolved
user-operator/src/test/java/io/strimzi/operator/user/UserControllerMockTest.java Outdated Show resolved Hide resolved
user-operator/src/test/java/io/strimzi/operator/user/ResourceUtils.java Outdated Show resolved Hide resolved
@see-quick
Configurable exclusion of labels in User Operator
7db7c13 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
maybe add a mock test
1007a5e 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
remove un-necessary
b218b20 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
update and address Jakub comments
223ad79 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
follow pattern from Labels to both CO and UO
3980c50 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
clean a bit
c766fe2 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick force-pushed the label-exclusion-user-operaotr branch from 91b0303 to c766fe2 Compare April 16, 2024 22:06
@see-quick
checkstyle
9519e45 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
update
35ed4f1 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
remove filter from method
bba5617 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
tempalte labels
1d89e8d 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
scholzj
scholzj reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess all we really need are the beter tests? 🤦

operator-common/src/main/java/io/strimzi/operator/common/model/Labels.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@see-quick
updated to tests
a922d82 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick changed the title Configurable exclusion of labels in User Operator Add more unit tests for Label.class related to label filtering Apr 17, 2024
@see-quick
update
3ae7ac4 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@scholzj scholzj merged commit 5376714 into strimzi:main Apr 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

Assignees

@see-quick see-quick

Labels
needs review
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@see-quick @scholzj