Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-restarting of MM2 connectors #9966

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 15, 2024

Type of change

  • Bugfix

Description

This PR fixes the auto-restarting feature for MM2 connectors. It seems that this feature never worked, because:

  • The auto-restart configuration was never passed to the ConnectorSpec passed to the connector operator
  • The connector operator was reading the wrong auto-restart status from MM2 but always from the KafkaConnector resource. So if the previous step ever worked, it would end up in an endless loop of very rapid restarts.

This PR fixes these issues and adds a unit test for it.

This should fix #9965.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Apr 15, 2024
@scholzj scholzj requested a review from ppatierno April 15, 2024 21:33
@scholzj
Copy link
Member Author

scholzj commented Apr 15, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits around javadoc and comments but otherwise looks good to me

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit a61861d into strimzi:main Apr 16, 2024
13 checks passed
@scholzj scholzj deleted the fix-MM2-connector-auto-restarting branch April 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MM2 connector auto-restarting does not seem to work
3 participants