Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too long timeout in Kubernetes-based IT tests #9968

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 15, 2024

Type of change

  • Bugfix

Description

Many of our IT tests use a specific namespace in a real Kubernetes cluster. In my environment, it seems that the deletion through the command line often fails and the namespace deletion gets stuck. However, because of how it is deleted, it waits for the deletion for 480 seconds which is very long. This PR changes how the namespaces are created and deleted to improve the reliability but also to shorten the wait times to fail quickly if needed.

Checklist

  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Apr 15, 2024
@see-quick
Copy link
Member

it seems that the deletion through the command line often fails and the namespace deletion gets stuck

A possible edge case is that some resources are still in that specific namespace and that's one reason why these namespaces are stuck :/. But for sure this seems to the an improvement (shorten timeouts...).

Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@scholzj
Copy link
Member Author

scholzj commented Apr 16, 2024

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Apr 16, 2024

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 72594bd into strimzi:main Apr 16, 2024
13 checks passed
@scholzj scholzj deleted the fix-long-timeout-in-resource-operator-IT-tests branch April 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants