Separate logging configuration and collecting plugin information from the conenctor reconciliation #9987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the conenctor reconciliation Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Apr 18, 2024
...tor/src/main/java/io/strimzi/operator/cluster/operator/assembly/AbstractConnectOperator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
deleted the
sepaarte-logging-update-and-plugins-from-connector-reconciliation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The dynamic update of logging configuration (in both MM2 and Connect) as well as gathering of information about plugins (Connect only) is currently hidden inside the connector reconciliation. That might make some sense for Connect, since these things are done only when the connector operator is enabled. But overall it makes it hard to read the code and understand what is done where. It also prevents us from sharing the code for updating the logging configuration between Connect and MM2.
I also found out we never update logging when connector operator is disabled. This is tracked in #9986 and not addressed in this PR.
This PR separates these actions into separate steps to give better overview of what is happening. But it does not change the basic premise that for Connect, both logging configuration and plugins info gathering happens only with enabled Connector operator.
Checklist