Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(exporter): adds the showAllOffsets configuration to example Exporter config #9991

Merged

Conversation

PaulRMellor
Copy link
Contributor

Documentation

Adds the showAllOffsets property to the example configuration of the Kafka Exporter.
The property is useful for stopping collecting metrics on disconnected consumers, which can skew metrics collection.
Plus some minor rewrites to the section.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

…a Exporter config

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor PaulRMellor added this to the 0.41.0 milestone Apr 17, 2024
@PaulRMellor PaulRMellor self-assigned this Apr 17, 2024
Signed-off-by: prmellor <pmellor@redhat.com>
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ppatierno ppatierno merged commit 8d005a5 into strimzi:main Apr 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants