Fixed deletion of cluster metadata on rollback after JBOD in KRaft support #9993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support Signed-off-by: Paolo Patierno <ppatierno@live.com>
ppatierno
commented
Apr 18, 2024
Signed-off-by: Paolo Patierno <ppatierno@live.com>
scholzj
approved these changes
Apr 18, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the deletion of cluster metadata when doing the migration rollback, by taking into account that now there is support for multiple JBOD disks in KRaft as well so there is the need to identify in which
datafolder they are stored to be correctly deleted.This PR doesn't add any new migration STs with a cluster having multiple JBOD disks. I tested it manually but a new PR will be opened for new STs.